Re: [alsa-devel] [PATCH 2/4] OMAP: mcbsp - add smart idle configuration API

On Tue, 18 May 2010 21:13:12 +0100 Liam Girdwood lrg@slimlogic.co.uk wrote:

Add a small API to configure McBSP smart idle modes to conserve power.

Signed-off-by: Liam Girdwood lrg@slimlogic.co.uk

arch/arm/plat-omap/include/plat/mcbsp.h | 15 ++++ arch/arm/plat-omap/mcbsp.c | 122 +++++++++++++++++++++++++++++++ 2 files changed, 137 insertions(+), 0 deletions(-)

+#define MCBSP_IDLE_FORCE 0 +#define MCBSP_IDLE_NONE 1 +#define MCBSP_IDLE_SMART 2

...

+int omap_mcbsp_set_idle_smart(unsigned int id, unsigned int clk_activity,

• unsigned int wake);
  

+int omap_mcbsp_set_idle_none(unsigned int id); +int omap_mcbsp_set_idle_force(unsigned int id); +int omap_mcbsp_get_idle_mode(unsigned int id);

Only minor comment but IMO single set function looks better. E.g.

omap_mcbsp_set_idle_mode(unsigned int id, int mode);