-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Friday, August 28, 2015 3:17 AM To: Oder Chiou Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; Flove; Bard Liao; John Lin; woojoo.lee@samsung.com Subject: Re: [PATCH v2] ASoC: rt5645: Prevent the pop sound of the headphone while rebooting or shutdowning
On Thu, Aug 27, 2015 at 03:14:51PM +0800, Oder Chiou wrote:
Add i2c shutdown function to prevent the pop sound of the headphone while the system is rebooting or shutdowning. It de-initials the jack detection function, and it cannot be turned off in _BIAS_OFF. If we don't de-initial it, the pop sound will be heard in the situation of powering off. And replace the related register settings from magic number to meaningful defined name.
A comment in the changelog is useful but I was really looking for one in the code here so people don't need to dive into the logs to understand what's going on.
Thank you for your kind remind and advice.