Hi Hans,
I love your patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next] [also build test WARNING on next-20210819] [cannot apply to v5.14-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/ASoC-Intel-rt5640-Add... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next config: x86_64-randconfig-a002-20210818 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/d447b4929d9936f4c0eeacdffeb8ed9ff09f... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Hans-de-Goede/ASoC-Intel-rt5640-Add-support-for-HP-Elite-Pad-1000G2-jack-detect/20210820-031104 git checkout d447b4929d9936f4c0eeacdffeb8ed9ff09fe01b # save the attached .config to linux build tree make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
sound/soc/intel/boards/bytcr_rt5640.c:493:5: warning: no previous prototype for 'byt_rt5640_hp_elitepad_1000g2_jack1_check' [-Wmissing-prototypes]
493 | int byt_rt5640_hp_elitepad_1000g2_jack1_check(void *data) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/intel/boards/bytcr_rt5640.c:509:5: warning: no previous prototype for 'byt_rt5640_hp_elitepad_1000g2_jack2_check' [-Wmissing-prototypes]
509 | int byt_rt5640_hp_elitepad_1000g2_jack2_check(void *data) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/byt_rt5640_hp_elitepad_1000g2_jack1_check +493 sound/soc/intel/boards/bytcr_rt5640.c
492
493 int byt_rt5640_hp_elitepad_1000g2_jack1_check(void *data)
494 { 495 struct byt_rt5640_private *priv = data; 496 int jack_status, mic_status; 497 498 jack_status = gpiod_get_value_cansleep(rt5640_jack_gpio.desc); 499 if (jack_status) 500 return 0; 501 502 mic_status = gpiod_get_value_cansleep(priv->hsmic_detect); 503 if (mic_status) 504 return SND_JACK_HEADPHONE; 505 else 506 return SND_JACK_HEADSET; 507 } 508
509 int byt_rt5640_hp_elitepad_1000g2_jack2_check(void *data)
510 { 511 struct snd_soc_component *component = data; 512 int jack_status, report; 513 514 jack_status = gpiod_get_value_cansleep(rt5640_jack2_gpio.desc); 515 if (jack_status) 516 return 0; 517 518 rt5640_enable_micbias1_for_ovcd(component); 519 report = rt5640_detect_headset(component, rt5640_jack2_gpio.desc); 520 rt5640_disable_micbias1_for_ovcd(component); 521 522 return report; 523 } 524
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org