-----Original Message----- From: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org Sent: Saturday, May 13, 2023 00:18 To: David.Rau.opensource David.Rau.opensource@dm.renesas.com; broonie@kernel.org Cc: support.opensource@diasemi.com; lgirdwood@gmail.com; perex@perex.cz; tiwai@suse.com; robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org; devicetree@vger.kernel.org; alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: da7219: Add Jack insertion detection polarity selection
On 12/05/2023 10:10, David Rau wrote:
DA7219 can support 2 kinds of insertion detection polarity
- Default polarity (Low)
- Inverted polarity (High)
This patch adds support for selecting insertion detection polarity to the DT binding.
Signed-off-by: David Rau David.Rau.opensource@dm.renesas.com
.../devicetree/bindings/sound/da7219.txt | 3 ++
Bindings are always separate patches. Consider also converting them to DT schema first.
Well noted and thanks for the kind suggestions. I will submit the binding change and driver code in different patch.
include/sound/da7219-aad.h | 6 ++++ sound/soc/codecs/da7219-aad.c | 34 +++++++++++++++++++ 3 files changed, 43 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/da7219.txt b/Documentation/devicetree/bindings/sound/da7219.txt index add1caf26ac2..357d1f61de1d 100644 --- a/Documentation/devicetree/bindings/sound/da7219.txt +++ b/Documentation/devicetree/bindings/sound/da7219.txt
Best regards, Krzysztof