On 3/4/20 1:06 PM, Mark Brown wrote:
On Wed, Mar 04, 2020 at 12:50:54PM -0600, Pierre-Louis Bossart wrote:
This thread is the first suggestion I've seen that this is any kind of bug fix. There's no Fixes tag and the patch description itself sounds like it's adding a new feature to enable new functionality in userspace (autodetection by UCM) and it was posted as part of a series "ASoC: SOF: initial cleanup for DT and multi-client support" which again doesn't give any indication that this might be supposed to be a bug fix.
the initial patch came from Jaroslav on 11/26, not from me. Quoting your own words:
"Since Pierre seems happy with it even if he didn't ack it explicitly I'll guess I'll apply it. If git can figure out applying it after the merge window and it doesn't get negative reviews there's no need to resend. If it can't and it doesn't turn up in a bigger series before then I'll let you know. "
Right, that's me saying I'll apply something that looks like normal development work after the merge window as with other normal development work (even Jaroslav's initial version was sent after the merge window opened), not that I'll apply it as a fix. There's no hint in any of that thread or in your resend that this was anything other than a new feature, and indeed you were talking about wanting to integrate it with a series that you didn't want to see in v5.5. Jaroslav mentioned not wanting to delay if it'd cause him to miss the merge window but didn't seem to complain when I said he'd missed it with his initial posting.
ok, I misunderstood your reply then. I thought you would provide it as an update for v5.5, thanks for the clarification
Anyway, is my understanding correct that this is fixing a regression caused by switching the default to SOF?
This is fixing a regression on platforms that have digital microphones, where SOF is automatically selected by default. For platforms without DMICs, the legacy driver is still used and this patch has no effect.