On Mon, 04 Dec 2017 16:43:45 +0100, Ughreja, Rakesh A wrote:
-----Original Message----- From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@linux.intel.com] Sent: Saturday, December 2, 2017 12:57 AM To: Ughreja, Rakesh A rakesh.a.ughreja@intel.com; alsa-devel@alsa- project.org; broonie@kernel.org; tiwai@suse.de; liam.r.girdwood@linux.intel.com Cc: Koul, Vinod vinod.koul@intel.com; Patches Audio patches.audio@intel.com Subject: Re: [alsa-devel] [RFC 05/10] ALSA: hda - make some of the functions externally visible
On 12/1/17 3:14 AM, Rakesh Ughreja wrote:
Mark some functions with EXPORT_SYMBOL_GPL so that it can be called by other kernel modules. These APIs would be called by ASoC based HDA codec driver which will be added in the later patches.
Looks ok. Just wondering from a code maintenance perspective if those functions would need to be part of a library, and if this means that to compile the ASoC based HDAudio codec support you still need to enable the legacy support - and if this leads to potential conflicts on which driver gets probed?
Yes, I think these functions are already part of library. These are part of file hda_codec.c, which looks like a library to me.
Takashi is that correct understanding ?
Yes, it's a library module.
Takashi