Hi Markus,
On Wed, Dec 18, 2013 at 12:57:40PM +0100, Markus Pargmann wrote:
irqs should only be requested/released with enabled DMA and not on MX21. MX21 has some special register write configurations, so we do not add support for statistics on mx21 for the moment.
Signed-off-by: Markus Pargmann mpa@pengutronix.de
sound/soc/fsl/fsl_ssi.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-)
@@ -227,13 +228,15 @@ static irqreturn_t fsl_ssi_isr(int irq, void *dev_id)
if (sisr & CCSR_SSI_SISR_RFRC) { ssi_private->stats.rfrc++;
sisr2 |= CCSR_SSI_SISR_RFRC;
if (ssi_private->hw_type != FSL_SSI_MX51)sisr2 |= CCSR_SSI_SISR_RFRC;ret = IRQ_HANDLED; }
if (sisr & CCSR_SSI_SISR_TFRC) { ssi_private->stats.tfrc++;
sisr2 |= CCSR_SSI_SISR_TFRC;
if (ssi_private->hw_type != FSL_SSI_MX51)sisr2 |= CCSR_SSI_SISR_TFRC;
I had a hard time on this part of modification because I just saw the commit comments 'not on MX21' until I checked the RM of imx35, which should be same as imx21 one: RFRC and RFRC became non-writeable since imx51. The should be the reason here right?
And just for curiosity, is there any wrong with this part, like causing SSI mis-behavior?
Thank you, Nicolin Chen