Re: [alsa-devel] [RFC 2/4] ASoC: core: Add delay operation to snd_soc_dai_ops

On Tuesday 02 March 2010 15:45:08 ext Mark Brown wrote:

On Tue, Mar 02, 2010 at 03:39:49PM +0200, Peter Ujfalusi wrote:

...

• /* Query the delay only for playback stream */
• if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {

• if (cpu_dai->ops->delay)
  

• 	delay += cpu_dai->ops->delay(substream, cpu_dai);
  

• if (codec_dai->ops->delay)
  

• 	delay += codec_dai->ops->delay(substream, codec_dai);
  

• runtime->delay = delay;
  

• }

I'd be inclined to leave this up to the drivers to avoid surprises if it becomes useful for the capture case in the future. Not sure that that's likely, but I'd rather avoid potential future transitions.

Sure, actually I have added this check later, since I had some trouble to make sensible reporting on the capture path. But sure, I can remove this check and leave it to the dais to deal with.

Thanks Peter