On 07/09/2022 16:21, luca.ceresoli@bootlin.com wrote:
From: Luca Ceresoli luca.ceresoli@bootlin.com
Add device tree bindings document for the audio card based on the internal I2S of the Rockchip RK3308 SoC.
Use subject prefixes matching the subsystem (git log --oneline -- ...).
Signed-off-by: Luca Ceresoli luca.ceresoli@bootlin.com
.../rockchip,rk3308-audio-graph-card.yaml | 50 +++++++++++++++++++ MAINTAINERS | 5 ++ 2 files changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/rockchip,rk3308-audio-graph-card.yaml
diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3308-audio-graph-card.yaml b/Documentation/devicetree/bindings/sound/rockchip,rk3308-audio-graph-card.yaml new file mode 100644 index 000000000000..8445a69dcdbb --- /dev/null +++ b/Documentation/devicetree/bindings/sound/rockchip,rk3308-audio-graph-card.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/rockchip,rk3308-audio-graph-card.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Rockchip RK3308 Audio card based on internal I2S
+maintainers:
- Luca Ceresoli luca.ceresoli@bootlin.com
+allOf:
- $ref: /schemas/sound/audio-graph.yaml#
+properties:
- compatible:
- const: rockchip,rk3308-audio-graph-card
Is "graph" part of device name or you just put it there because of other schema? The compatible should reflect the device name, not some other pieces in Linux or in bindings.
+required:
- compatible
+unevaluatedProperties: false
+examples:
- |
- sound {
compatible = "rockchip,rk3308-audio-graph-card";dais = <&i2s_8ch_2_port>;- };
- i2s_8ch_2 {
No underscores in node names. Generic node names. This does not look like related example...
i2s_8ch_2_port: port {i2s_8ch_2_endpoint: endpoint {remote-endpoint = <&acodec_endpoint>;dai-format = "i2s";/* The RK3308 acodec has no clock dividers, use the CPU */bitclock-master = <&i2s_8ch_2_endpoint>;frame-master = <&i2s_8ch_2_endpoint>;};};- };
- acodec {
codec or audio-codec
port {acodec_endpoint: endpoint {remote-endpoint = <&i2s_8ch_2_endpoint>;};};- };
diff --git a/MAINTAINERS b/MAINTAINERS index d53a8e74cb1e..079bdd95dc49 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17594,6 +17594,11 @@ S: Maintained F: Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml F: include/dt-bindings/sound/rockchip,rk3308-codec.h
+ROCKCHIP RK3308 SOUND CARD DRIVER +M: Luca Ceresoli luca.ceresoli@bootlin.com +S: Maintained +F: Documentation/devicetree/bindings/sound/rockchip,rk3308-audio-graph-card.yaml
ROCKCHIP VIDEO DECODER DRIVER M: Ezequiel Garcia ezequiel@vanguardiasur.com.ar L: linux-media@vger.kernel.org
Best regards, Krzysztof