On Mon, 10 Jan 2022 11:21:11 +0100, Andy Shevchenko wrote:
On Mon, Jan 10, 2022 at 2:37 AM Tom Rix trix@redhat.com wrote:
On 1/9/22 2:33 PM, Andy Shevchenko wrote: On Saturday, January 8, 2022, trix@redhat.com wrote:
...
if (unlikely(ret)) {This is double weird. First of all, wtf unlikely is here? Second, I commented on the patch that does something with this driver and pointed out to the return 0 in some cases. This one seems a band aid.
Unlikely to have an error.
We don't use likely() and unlikely() here and there, you need to provide a very good justification of its use.
For the record, I forwarded you my review against the code where you can find much more issues with it that are subject to fix / amend.
For this particular bug fix, Dan submitted a simpler patch and I took it now: https://lore.kernel.org/r/20220111072232.GG11243@kili
thanks,
Takashi