Re: [PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15

On Thu, May 11, 2023 at 06:06:14PM +0200, Takashi Iwai wrote:

On Wed, 10 May 2023 18:19:08 +0200, Ryan C. Underwood wrote:

...

The Pavilion 15 line has B&O top speakers similar to the x360 and applying the same profile produces good sound. Without this, the sound would be tinny and underpowered without either applying model=alc295-hp-x360 or booting another OS first.

The code change looks OK, but could you give your Signed-off-by tag? It's a legal requirement and mandatory for merging to the upstream.

I'll send a new patch with that updated.

Also, you can reduce the recipients in Cc a bit more. For this kind of trivial change, just maintainers and ML should suffice.

Sorry, I just used the output of get_maintainer.pl...