28 Aug
2013
28 Aug
'13
7:24 p.m.
On Wed, Aug 28, 2013 at 05:20:10PM +0200, Lars-Peter Clausen wrote:
+static const char * const adau1761_bias_select_text[] = {
- "Normal operation", "Enhanced performance", "Power saving",
+};
+static const char * const adau1761_bias_select_extreme_text[] = {
- "Normal operation", "Extreme power saving", "Enhanced performance",
- "Power saving",
+};
Not a requirement and perhaps it has no effect but these seem like they ought to integrate with the bias level configuration - since only the clocks seem to be managed by set_bias_level() the driver could presumably save a bit of power by dropping down to the minimal power consumption bias while the device is idle. This is what the STANDBY to ON transition is all about.
+static const struct snd_kcontrol_new adau1761_jack_detect_controls[] = {
- SOC_SINGLE("Jack Detect Switch", ADAU1761_DIGMIC_JACKDETECT, 4, 1, 0),
+};
Why is this a user visible control and not using the jack detection framework support?