Hi Gustavo,
Thanks for your patch!
On Mon, Jul 29, 2019 at 4:33 PM Gustavo A. R. Silva gustavo@embeddedor.com wrote:
Mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
sound/oss/dmasound/dmasound_atari.c: warning: this statement may fall through [-Wimplicit-fallthrough=]: => 1449:24
Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find.
Have you compile-tested this?
This doesn't work with gcc version 8.2.0 (Ubuntu 8.2.0-1ubuntu2~18.04). Turns out the warning only goes away when converting the indentation of the switch() statement to match kernel style... Silly gcc...
Reported-by: Geert Uytterhoeven geert@linux-m68k.org Signed-off-by: Gustavo A. R. Silva gustavo@embeddedor.com
sound/oss/dmasound/dmasound_atari.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/oss/dmasound/dmasound_atari.c b/sound/oss/dmasound/dmasound_atari.c index 83653683fd68..b5845e904ba1 100644 --- a/sound/oss/dmasound/dmasound_atari.c +++ b/sound/oss/dmasound/dmasound_atari.c @@ -1449,7 +1449,7 @@ static int FalconMixerIoctl(u_int cmd, u_long arg) tt_dmasnd.input_gain = RECLEVEL_VOXWARE_TO_GAIN(data & 0xff) << 4 | RECLEVEL_VOXWARE_TO_GAIN(data >> 8 & 0xff);
/* fall thru, return set value */
/* fall through - return set value */ case SOUND_MIXER_READ_MIC: return IOCTL_OUT(arg, RECLEVEL_GAIN_TO_VOXWARE(tt_dmasnd.input_gain >> 4 & 0xf) |
Gr{oetje,eeting}s,
Geert