18 Mar
2021
18 Mar
'21
3:25 p.m.
On Thu, 18 Mar 2021 14:20:08 +0100, Colin King wrote:
From: Colin Ian King colin.king@canonical.com
The shifting of the u8 integer device by 24 bits to the left will be promoted to a 32 bit signed int and then sign-extended to a 64 bit unsigned long. In the event that the top bit of device is set then all then all the upper 32 bits of the unsigned long will end up as also being set because of the sign-extension. Fix this by casting device to an unsigned long before the shift.
Addresses-Coverity: ("Unintended sign extension") Fixes: a07df82c7990 ("ALSA: usb-audio: Add DJM750 to Pioneer mixer quirk") Signed-off-by: Colin Ian King colin.king@canonical.com
Thanks, applied now.
Takashi