28 Aug
2018
28 Aug
'18
9:40 p.m.
On Tue, Aug 21, 2018 at 06:52:46PM +0200, Kirill Marinushkin wrote:
This looks good apart from a few small stylistic things so I'll apply, please send followup patches fixing these:
+++ b/sound/soc/codecs/pcm3060-i2c.c @@ -0,0 +1,61 @@ +// SPDX-License-Identifier: GPL-2.0 +/*
- PCM3060 I2C driver
Please make the entire comment a C++ one, it makes this look more intentional.
- reg = (dai->id == PCM3060_DAI_ID_DAC ? PCM3060_REG67 : PCM3060_REG72);
Please rewrite this as a normal if statement to improve legibility, there's some other ternery operator abuse in here.