-----Original Message----- From: Vinod Koul [mailto:vinod.koul@intel.com] Sent: Wednesday, April 26, 2017 1:38 PM To: weiyongjun (A) weiyongjun1@huawei.com Cc: Wei Yongjun weiyj.lk@gmail.com; Liam Girdwood lgirdwood@gmail.com; Mark Brown broonie@kernel.org; Jaroslav Kysela perex@perex.cz; Takashi Iwai tiwai@suse.com; Pardha Saradhi K pardha.saradhi.kesapragada@intel.com; G Kranthi gudishax.kranthikumar@intel.com; Hardik T Shah hardik.t.shah@intel.com; Jeeja KP jeeja.kp@intel.com; alsa- devel@alsa-project.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] ASoC: Intel: Skylake: Fix to use list_for_each_safe() when delete items
On Tue, Apr 25, 2017 at 07:57:57AM +0000, weiyongjun (A) wrote:
Since we will remove items off the list using list_del() we need to use a safe version of the list_for_each() macro aptly named list_for_each_safe().
ah yes, god catch
This is detected by Coccinelle semantic patch.
It is a good practice to include the script you used, do you mind adding that in the log?
Sure.
Sorry I meant this should be in changelog of the patch :)
OK, I will add this and send the v2 version patch later.