On Mon, Sep 19, 2022 at 02:36:16PM +0200, Pierre-Louis Bossart wrote:
In preparation of the IPCv4 IPC support, this patch adds support for SkyLake and KabyLake boot and descriptors used when probing the PCI driver.
This breaks an x86_64 allmodconfig build:
In file included from /build/stage/linux/sound/soc/sof/intel/hda-loader-skl.c:25: /build/stage/linux/sound/soc/sof/intel/hda-loader-skl.c: In function ‘cl_dsp_init_skl’: /build/stage/linux/sound/soc/sof/intel/hda-loader-skl.c:372:56: error: ‘HDA_DSP_ROM_STS_MASK’ undeclared (first use in this function) 372 | ((status & HDA_DSP_ROM_STS_MASK) | ^~~~~~~~~~~~~~~~~~~~ /build/stage/linux/sound/soc/sof/intel/../ops.h:551:21: note: in definition of macro ‘snd_sof_dsp_read_poll_timeout’ 551 | if (cond) { \ | ^~~~ /build/stage/linux/sound/soc/sof/intel/hda-loader-skl.c:372:56: note: each undeclared identifier is reported only once for each function it appears in 372 | ((status & HDA_DSP_ROM_STS_MASK) | ^~~~~~~~~~~~~~~~~~~~ /build/stage/linux/sound/soc/sof/intel/../ops.h:551:21: note: in definition of macro ‘snd_sof_dsp_read_poll_timeout’ 551 | if (cond) { \ | ^~~~ /build/stage/linux/sound/soc/sof/intel/hda-loader-skl.c:373:49: error: ‘HDA_DSP_ROM_INIT’ undeclared (first use in this function); did you mean ‘HDA_DSP_REG_HIPCT’? 373 | == HDA_DSP_ROM_INIT), | ^~~~~~~~~~~~~~~~ /build/stage/linux/sound/soc/sof/intel/../ops.h:551:21: note: in definition of macro ‘snd_sof_dsp_read_poll_timeout’ 551 | if (cond) { \ | ^~~~ /build/stage/linux/sound/soc/sof/intel/hda-loader-skl.c: In function ‘hda_dsp_cl_boot_firmware_skl’: /build/stage/linux/sound/soc/sof/intel/hda-loader-skl.c:553:53: error: ‘HDA_DSP_ROM_STS_MASK’ undeclared (first use in this function) 553 | ((reg & HDA_DSP_ROM_STS_MASK) | ^~~~~~~~~~~~~~~~~~~~ /build/stage/linux/sound/soc/sof/intel/../ops.h:551:21: note: in definition of macro ‘snd_sof_dsp_read_poll_timeout’ 551 | if (cond) { \ | ^~~~ /build/stage/linux/sound/soc/sof/intel/hda-loader-skl.c:554:49: error: ‘HDA_DSP_ROM_RFW_START’ undeclared (first use in this function); did you mean ‘HDA_DSP_SRAM_REG_FW_STATUS’? 554 | == HDA_DSP_ROM_RFW_START), | ^~~~~~~~~~~~~~~~~~~~~ /build/stage/linux/sound/soc/sof/intel/../ops.h:551:21: note: in definition of macro ‘snd_sof_dsp_read_poll_timeout’ 551 | if (cond) { \ | ^~~~ make[5]: *** [/build/stage/linux/scripts/Makefile.build:249: sound/soc/sof/intel/hda-loader-skl.o] Error 1 make[5]: Target '__build' not remade because of errors. make[4]: *** [/build/stage/linux/scripts/Makefile.build:465: sound/soc/sof/intel] Error 2 make[4]: Target '__build' not remade because of errors. make[3]: *** [/build/stage/linux/scripts/Makefile.build:465: sound/soc/sof] Error 2 make[3]: Target '__build' not remade because of errors. make[2]: *** [/build/stage/linux/scripts/Makefile.build:465: sound/soc] Error 2 make[2]: Target '__build' not remade because of errors. make[1]: *** [/build/stage/linux/Makefile:1852: sound] Error 2 make[1]: Target '__all' not remade because of errors. make: *** [Makefile:222: __sub-make] Error 2