On Wed, Jul 12, 2023 at 02:19:47PM +0200, Amadeusz Sławiński wrote:
On 7/11/2023 4:33 PM, Andy Shevchenko wrote:
On Tue, Jul 11, 2023 at 02:57:26PM +0200, Amadeusz Sławiński wrote:
Use PCI device IDs from pci_ids.h header.
...
switch (sst->dev_id) {
- case SST_MRFLD_PCI_ID:
- case PCI_DEVICE_ID_INTEL_ADSP_TNG: case SST_BYT_ACPI_ID: case SST_CHV_ACPI_ID:
I think this needs a bit more, i.e. replacing the rest with respective PCI IDs.
All three will be defined with SST prefix, which makes sense to me.
ACPI here is a bit misleading, but correct. The ACPI specification assumes that respective part of the ID space covers 100% of PCI ID space.
I have briefly checked the code and it seems that ID is used externally only for PCI case, so we may simply use the lower 16 bits of the ACPI _HID for the context.
Do I understand correctly that I should just do: #define PCI_DEVICE_ID_INTEL_SST_BYT 0x0F28 #define PCI_DEVICE_ID_INTEL_SST_CHV 0x22A8 and use those IDs instead?
Correct!