28 Jul
2008
28 Jul
'08
7:47 p.m.
On Mon, Jul 28, 2008 at 07:01:19PM +0200, Takashi Iwai wrote:
They are bitmask, so HEADSET should be better defined as SND_JACK_HEADPHONE | SND_JACK_MICROPHONE ?
Done.
+void snd_jack_set_parent(struct snd_jack *jack, struct device *parent) +{
- BUG_ON(jack->registered);
I'm afraid BUG_ON() is brutal for this kind of check.
I'll change it down to a WARN_ON() but I do feel that this is something that should be complained about loudly, it's a clear error to try to reparent the instantiated device.