On Sat, Mar 21, 2020 at 1:50 AM Rob Herring robh@kernel.org wrote:
On Mon, Mar 09, 2020 at 11:58:33AM +0800, Shengjiu Wang wrote:
EASRC (Enhanced Asynchronous Sample Rate Converter) is a new IP module found on i.MX8MN.
Signed-off-by: Shengjiu Wang shengjiu.wang@nxp.com
.../devicetree/bindings/sound/fsl,easrc.yaml | 101 ++++++++++++++++++ 1 file changed, 101 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/fsl,easrc.yaml
diff --git a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml new file mode 100644 index 000000000000..ff22f8056a63 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml @@ -0,0 +1,101 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/fsl,easrc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: NXP Asynchronous Sample Rate Converter (ASRC) Controller
+maintainers:
- Shengjiu Wang shengjiu.wang@nxp.com
+properties:
- $nodename:
- pattern: "^easrc@.*"
- compatible:
- const: fsl,imx8mn-easrc
- reg:
- maxItems: 1
- interrupts:
- maxItems: 1
- clocks:
- items:
- description: Peripheral clock- clock-names:
- items:
- const: mem- dmas:
- maxItems: 8
- dma-names:
- items:
- const: ctx0_rx- const: ctx0_tx- const: ctx1_rx- const: ctx1_tx- const: ctx2_rx- const: ctx2_tx- const: ctx3_rx- const: ctx3_tx- fsl,easrc-ram-script-name:
'firmware-name' is the established property name for this.
will use "firmware-name"
- allOf:
- $ref: /schemas/types.yaml#/definitions/string- const: imx/easrc/easrc-imx8mn.binThough if there's only 1 possible value, why does this need to be in DT?
- description: The coefficient table for the filters
If the firmware is only 1 thing, then perhaps this should just be a DT property rather than a separate file. It depends on who owns/creates this file. If fixed for the platform, then DT is a good fit. If updated separately from DT and boot firmware, then keeping it separate makes sense.
The firmware is not fixed for the platform, it is updated separately from DT. So we can keep it separately.
best regards wang shengjiu