Hi, sorry for the style problems. See attached for better version.
Damien
On 31/10/14 14:29, Takashi Sakamoto wrote:
Hi Damien,
On Oct 31 2014 10:57, Damien Zammit wrote:
This patch provides a mixer control for selecting the clock source of the Digidesign Mbox 1 to either internal clock or S/PDIF external. Trial and error and bus snooping were the only way to get this information, but it works on the hardware.
This patch includes lines over 80 characters. Furthermore, these lines include inappropriate white-space for indentation. How about indenting with tab only and add more line-breaks between each function parameter?
$ ./scripts/checkpatch.pl /tmp/0001-mbox1-spdif.patch WARNING: line over 80 characters #134: FILE: sound/usb/mixer_quirks.c:641:
usb_rcvctrlpipe(mixer->chip->dev,0), 0x81,
WARNING: line over 80 characters #135: FILE: sound/usb/mixer_quirks.c:642:
USB_DIR_IN | USB_TYPE_CLASS |USB_RECIP_INTERFACE,
WARNING: line over 80 characters #140: FILE: sound/usb/mixer_quirks.c:647:
usb_rcvctrlpipe(mixer->chip->dev,0), 0x81,
WARNING: line over 80 characters #141: FILE: sound/usb/mixer_quirks.c:648:
USB_DIR_IN | USB_TYPE_CLASS |USB_RECIP_ENDPOINT,
WARNING: line over 80 characters #159: FILE: sound/usb/mixer_quirks.c:666:
usb_rcvctrlpipe(mixer->chip->dev,0), 0x81,
WARNING: line over 80 characters #160: FILE: sound/usb/mixer_quirks.c:667:
USB_DIR_IN | USB_TYPE_CLASS |USB_RECIP_ENDPOINT,
WARNING: line over 80 characters #165: FILE: sound/usb/mixer_quirks.c:672:
usb_rcvctrlpipe(mixer->chip->dev,0), 0x81,
WARNING: line over 80 characters #166: FILE: sound/usb/mixer_quirks.c:673:
USB_DIR_IN | USB_TYPE_CLASS |USB_RECIP_ENDPOINT,
total: 0 errors, 8 warnings, 226 lines checked
/tmp/0001-mbox1-spdif.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
Regards
Takashi Sakamoto o-takashi@sakamocchi.jp