Re: [PATCH v2] component: do not leave master devres group open after bind

On Wed, 22 Sep 2021 10:54:32 +0200, Kai Vehmanen wrote: (snip)

--- a/drivers/base/component.c +++ b/drivers/base/component.c @@ -246,7 +246,7 @@ static int try_to_bring_up_master(struct master *master, return 0; }

• if (!devres_open_group(master->parent, NULL, GFP_KERNEL))

• if (!devres_open_group(master->parent, master, GFP_KERNEL)) return -ENOMEM;

  /* Found all components */

@@ -258,6 +258,7 @@ static int try_to_bring_up_master(struct master *master, return ret; }

• devres_close_group(master->parent, NULL);

Just wondering whether we should pass master here instead of NULL, too?

thanks,

Takashi