Re: [alsa-devel] [PATCH 1/3] ALSA: ac97: Fix of-node refcount unbalance

Takashi Iwai tiwai@suse.de writes:

ac97_of_get_child_device() take the refcount of the node explicitly via of_node_get(), but this leads to an unbalance. The for_each_child_of_node() loop itself takes the refcount for each iteration node, hence you don't need to take the extra refcount again.

Fixes: 2225a3e6af78 ("ALSA: ac97: add codecs devicetree binding") Signed-off-by: Takashi Iwai tiwai@suse.de

---

Only compile-tested. Please review carefully. Thanks!

Hi Takashi,

Reviewed-by: Robert robert.jarzmik@free.fr

Cheers.

-- Robert