On Wed, Dec 21, 2011 at 03:42:17PM +0100, Takashi Iwai wrote:
Well, the kctl-jack part itself can't break anything right now since it's used only in HD-audio. If others will use, this will be a pure addition, so it won't break except for possibly different ctl numids.
A pure addition can still cause problems as we roll out the same interface into other drivers, for example if there's assumptions that aren't generally true.
+void snd_kctl_jack_report(struct snd_card *card,
struct snd_kcontrol *kctl, bool status)+{
- if (kctl->private_value == status)
return;- kctl->private_value = status;
- snd_ctl_notify(card, SNDRV_CTL_EVENT_MASK_VALUE, &kctl->id);
+} +EXPORT_SYMBOL_GPL(snd_kctl_jack_report);
So, this looks good in so far as it goes but obviously there's no semantics being defined here for the controls or their names. That's more the bit that worries me as we'll get applications starting to use the new interface and they should have something consistent to work with.
I'm guessing that as this is just a simple boolean each jack will have a series of controls like "Headset Jack Headphone" and "Headset Jack Microphone" or whatever and userspace should match them all together in the same way that it does for Volume and Switch controls? That sounds like it'll work well, we just need to define some strings for standard jacks and conections.