On Wed, Apr 08, 2015 at 03:27:37PM +0300, Dan Carpenter wrote:
On Wed, Apr 08, 2015 at 05:20:10PM +0530, Sudip Mukherjee wrote:
On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote:
- We can't apply this patch on its own so this way of breaking up the
patches doesn't work.
yes, if the first patch is reverted for any reason all the others need to be reverted also. so then everything in one single patch?
The problem is that patch 1/1 breaks the build. The rule is that we should be able to apply part of a patch series and nothing breaks. If we apply the patch series out of order than things break that's our problem, yes. But if we apply only 1/1 and it breaks, that's a problem with the series.
Yep, keep in mind that "git bisect" will randomly land in the middle of any set of patches during a debugging session and it could very well land on this one. If it breaks, that's a real pain for the people trying to bisect their bug because suddenly they have to deal with a second bug totally different from theirs.
Regards, Willy