24 Sep
2020
24 Sep
'20
8:59 p.m.
On Thu, 24 Sep 2020 18:10:19 +0200, Kai Vehmanen wrote:
Hey,
On Thu, 24 Sep 2020, Takashi Iwai wrote:
On Thu, 24 Sep 2020 17:40:43 +0200, Kai Vehmanen wrote:
Document missing function arguments and fix make W=1 warning:
Do we really need to put this internal function in the API documents? If not, the right fix would be to drop the kerneldoc marker instead.
I was puzzled at this as well. I took a look at some static internal functions and there were both with (e.g. snd_hdac_make_cmd()) and without kerneldoc markers.
Some might have been exported functions in the past.
But, but, granted, this is without any name prefix, so maybe better to drop the kerneldoc. Let me send a v2.
OK, thanks.
Takashi