28 Nov
2007
28 Nov
'07
1:56 p.m.
At Wed, 28 Nov 2007 08:18:57 -0500, Dave Dillow wrote:
Also, replace __ffs() only for 2.4 kernels, e.g.
I'm 50/50 on this -- it doesn't hurt to just use the patched in version, even in 2.6. I'm not fond of #ifdefs in code, and I'd need to search for when it became available.
But a different code would be compiled even for the same kernel and with the same config, between alsa-driver and kernel builds. That's what I'd like to avoid.
Then again, it is a small patch and the research isn't hard, just a bit time consuming.
__ffs() is present on all 2.6 versions. So, >= 2.6.0 should be OK.
thanks,
Takashi