29 Jun
2012
29 Jun
'12
10:35 a.m.
On 6/28/2012 5:57 PM, Mark Brown wrote:
On Thu, Jun 28, 2012 at 12:31:39PM +0530, Rajeev Kumar wrote:
- void *io_base;
Should be __iomem. Looking at the code I suspect this might benefit from using regmap like Tegra, you'd save having to open code your mute control if nothing else.
OK
+static const struct snd_kcontrol_new spdif_out_controls[] = {
- SOC_SINGLE_BOOL_EXT("SPDIF Play Mute", (unsigned long)&spdif_out_mute,
spdif_mute_get, spdif_mute_put),Should be "IEC958 Playback Switch".
OK
+int spdif_soc_dai_probe(struct snd_soc_dai *dai) +{
- struct snd_soc_card *card = dai->card;
- struct snd_soc_pcm_runtime *rtd = card->rtd;
- struct snd_soc_codec *codec = rtd->codec;
- return snd_soc_add_codec_controls(codec, spdif_out_controls,
ARRAY_SIZE(spdif_out_controls));We should add a framework thing for this...
- .ops = (struct snd_soc_dai_ops *)&spdif_out_dai_ops,
Why do you need this cast?
It was a const I think
Regards Vipin