On 03/02/2012 02:59 PM, Mark Brown wrote:
On Wed, Feb 22, 2012 at 10:49:08AM +0100, Lars-Peter Clausen wrote:
This patch adds a set of functions which are intended to be used when implementing a dmaengine based sound PCM driver.
Having this framework is a substantial win and I got bored waiting for the repost of this and the subsequent patches (especially given that the merge window is drawing nearer). Since the fix for ep93xx is so simple and it works on i.MX I went ahead and applied everything except the ep93xx conversion. Thanks!
Please resend the ep93xx conversion along with the tweak to the core so we can get that working.
I was at trade show for the rest of last week, without much time for anything else. I will submit the missing patches in a moment.
It would also be good to update FSI to use this library as it's also using dmaengine (the patch having been merged just before this one it got missed in the updates I expect).
I've had a look at the FSI dmaengine driver and it is not straight forward to convert. For one it does not use cyclic dma transfers so it is more something for Russel's patch and on the other hand the FSI PCM driver introduces another layer of indirection which is used to be able to switch between PIO and DMA. But as a result the functions the dmaengine PCM framework provides don't really fit anymore.
- Lars