Re: [PATCH -next 1/4] ASoC: samsung: i2s: Use devm_platform_get_and_ioremap_resource()

On 16/06/2021 11:16, Yang Yingliang wrote:

Use devm_platform_get_and_ioremap_resource() to simplify code.

Signed-off-by: Yang Yingliang yangyingliang@huawei.com

sound/soc/samsung/i2s.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index c632842d42eb..309badc97290 100644 --- a/sound/soc/samsung/i2s.c +++ b/sound/soc/samsung/i2s.c @@ -1441,8 +1441,7 @@ static int samsung_i2s_probe(struct platform_device *pdev) } }

• res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
• priv->addr = devm_ioremap_resource(&pdev->dev, res);

• priv->addr = devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(priv->addr)) return PTR_ERR(priv->addr);

Reviewed-by: Krzysztof Kozlowski krzysztof.kozlowski@canonical.com

Best regards, Krzysztof