On Thu, Jul 25, 2019 at 2:14 AM Nicolin Chen nicoleotsuka@gmail.com wrote:
On Mon, Jul 22, 2019 at 03:48:29PM +0300, Daniel Baluta wrote:
SAI supports up to 8 data lines. This property let the user configure how many data lines should be used per transfer direction (Tx/Rx).
Signed-off-by: Daniel Baluta daniel.baluta@nxp.com
Documentation/devicetree/bindings/sound/fsl-sai.txt | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt index 2e726b983845..59f4d965a5fb 100644 --- a/Documentation/devicetree/bindings/sound/fsl-sai.txt +++ b/Documentation/devicetree/bindings/sound/fsl-sai.txt @@ -49,6 +49,11 @@ Optional properties:
- fsl,dl_mask : list of two integers (bitmask, first for RX, second
Not quite in favor of the naming here; And this patch should be sent to the devicetree maillist and add DT maintainers -- they would give some good naming advice.
From my point of view, I feel, since data lines are enabled consecutively, probably it'd be clear just to have something like "fsl,num-datalines = <2 2>", corresponding to "dl_mask = <0x3 0x3>". I believe there're examples in the existing DT bindings, so let's see how others suggest.
Your suggestion looks good to me. Anyhow, after reading again the documentation it seems that datalines are not always required to be consecutive.
The need to be consecutive only when FIFO combine mode is enabled. Will fix the documentation in the next version.