Re: [alsa-devel] [PATCH] Add support for CLKOUT to wm8731 codec driver

Mark Brown wrote:

...

• dev_dbg(codec->dev, PREFIX "%s turning off CLKOUT\n", __func__);
  

• reg = wm8731_read_reg_cache(codec, WM8731_PWR);
  

• reg |= (1 << WM8731_PWR_CLKOUTPD);
  

• wm8731_write(codec, WM8731_PWR, reg);
  

• }

It'd be better define a new clock for the CLKOUT pin rather than munging it in with the master clock. MCLK is always an input on the WM8731, the CLKOUT output is a separate pin and so including it in MCLK is likely to make things confusing and could well introduce errors.

Could you explain more about what you meant by this? I'm trying to rework these patches now, and I don't understand how to implement what you are suggesting.

b.g.