On 30/06/2021 14:18, Dan Carpenter wrote:
This code checks "priv->mclk_freq" twice and the second check is not required. The code is left over from when removed support for legacy boot.
Good find, thank you!
Acked-by: Peter Ujfalusi peter.ujfalusi@gmail.com
Fixes: 8fe120b5a665 ("ASoC: omap-abe-twl6040: Remove support for pdata (legacy boot)") Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
sound/soc/ti/omap-abe-twl6040.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/sound/soc/ti/omap-abe-twl6040.c b/sound/soc/ti/omap-abe-twl6040.c index 91cc9a4f44d7..2e3d1eea77c1 100644 --- a/sound/soc/ti/omap-abe-twl6040.c +++ b/sound/soc/ti/omap-abe-twl6040.c @@ -292,11 +292,6 @@ static int omap_abe_probe(struct platform_device *pdev)
card->fully_routed = 1;
- if (!priv->mclk_freq) {
dev_err(&pdev->dev, "MCLK frequency missing\n");return -ENODEV;- }
- card->dai_link = priv->dai_links; card->num_links = num_links;