8 Jan
2011
8 Jan
'11
1:04 a.m.
On Fri, Jan 07, 2011 at 03:31:36PM -0800, Stephen Warren wrote:
Is this intended; should the WM8903 driver not be enabling SYS_ENA so broadly. Perhaps e.g. it should only be enabled during SND_SOC_BIAS_ON/_PREPARE, and not during _STANDBY?
It's enabled because the initial bringup of the device uses the write sequencer which relies on the MCLK, and more practically because devices of the era that the driver was written were rarely able to manage the external clock.
For the initial driver submission I suggest fixing the MCLK rate for 44.1kHz and leaving it on all the time under the control of the machine driver, I'll make sure someone from Wolfson enhances the WM8903 driver so that the machine driver can be made more flexible.