Re: [alsa-devel] [PATCH] ASoC: dapm: Fix NULL pointer dereference when registering card with widgets

On 10/03/2014 02:32 PM, Jarkko Nikula wrote:

Commit 0bd2ac3dae74 ("ASoC: Remove CODEC pointer from snd_soc_dapm_context") introduced regression to snd_soc_dapm_new_controls() when registering a card with card->dapm_widgets set. Call chain is:

 snd_soc_register_card()
 -> snd_soc_instantiate_card()
    -> snd_soc_dapm_new_controls()
       -> snd_soc_dapm_new_control()

Null pointer dereference occurs since card->dapm context doesn't have associated component. Fix this by setting widget codec pointer conditionally.

Signed-off-by: Jarkko Nikula jarkko.nikula@linux.intel.com

Thanks. Stupid mistake.

Acked-by: Lars-Peter Clausen lars@metafoo.de