12 Jul
2023
12 Jul
'23
12:20 p.m.
On 7/12/23 08:15, Lu, Brent wrote:
- {
.id = "10EC5650",.drv_name = "jsl_rt5650",.machine_quirk = snd_soc_acpi_codec_list,.quirk_data = &rt5650_spk,.sof_tplg_filename = "sof-jsl-rt5650-dual.tplg",what does 'dual' mean in this context? it's not something we've used before so a comment would be needed IMHO.
two DAIs, two codecs?
Dual I2S. Should we remove it? Just sof-jsl-rt5650.tplg?
that would be my preference, we have lots of configurations with 2 I2S and never mention it in the topology file name. 'dual' sounds more confusing than helping here.
The rest of the patch is fine.