Re: [alsa-devel] [PATCH 3/3] ASoC: mxs: add some error messages to help identifying problems

On Wed, Jul 31, 2013 at 11:44 AM, Lothar Waßmann LW@karo-electronics.de wrote:

    /* Set SGTL5000's SYSCLK (provided by SAIF MCLK) */
    ret = snd_soc_dai_set_sysclk(codec_dai, SGTL5000_SYSCLK, mclk, 0);

•   if (ret)
  

•   if (ret) {
  

•           dev_err(codec_dai->dev, "Failed to set sysclk to %u kHz\n",
  

•                   mclk / 1000);
  

Wouldn't it make more sense to express it in MHz instead of kHz?

            return ret;

•   }
  
    /* The SAIF MCLK should be the same as SGTL5000_SYSCLK */
    ret = snd_soc_dai_set_sysclk(cpu_dai, MXS_SAIF_MCLK, mclk, 0);
  

•   if (ret)
  

•   if (ret) {
  

•           dev_err(cpu_dai->dev, "Failed to set sysclk to %u kHz\n",
  

•                   mclk / 1000);
  

Same here.