On Tue, 14 Nov 2023 14:31:25 +0100, Saarinen, Jani wrote:
Hi,
-----Original Message----- From: Maarten Lankhorst maarten.lankhorst@linux.intel.com Sent: Tuesday, November 14, 2023 3:30 PM To: Jani Nikula jani.nikula@linux.intel.com; Ville Syrjälä ville.syrjala@linux.intel.com Cc: Takashi Iwai tiwai@suse.de; intel-gfx@lists.freedesktop.org; intel- xe@lists.freedesktop.org; alsa-devel@alsa-project.org; Saarinen, Jani jani.saarinen@intel.com; Kurmi, Suresh Kumar suresh.kumar.kurmi@intel.com Subject: Re: [Intel-xe] [PATCH 11/14] ALSA: hda/intel: Move snd_hdac_i915_init to before probe_work.
Hey,
Den 2023-11-14 kl. 13:35, skrev Jani Nikula:
On Tue, 14 Nov 2023, Ville Syrjälä ville.syrjala@linux.intel.com wrote:
On Mon, Oct 02, 2023 at 09:38:44PM +0200,
maarten.lankhorst@linux.intel.com wrote:
From: Maarten Lankhorst maarten.lankhorst@linux.intel.com
Now that we can use -EPROBE_DEFER, it's no longer required to spin off the snd_hdac_i915_init into a workqueue.
Use the -EPROBE_DEFER mechanism instead, which must be returned in the probe function.
This completely broke i915 audio!
I also can't see any trace of this stuff ever being posted to intel-gfx so it never went through the CI.
Please fix or revert ASAP.
Cc: Jani, Suresh
Ville, please file a bug at gitlab so we can track this, thanks.
I've originally tested this on TGL and DG2, so can you be more specific on what broke?
Was this series tested on CI ever as Ville saying no? How this got merged?
Hm, I somehow believed that patches have been tested by intel people, as they came from intel. (Also thought that drm-tip or whatever tree also drags the recent changes from sound.git tree for relevant part.)
In anyway, the whole patches were touching only sound/* files and no changes in DRM side at all, hence they weren't sent to intel-gfx, I suppose.
Takashi