Pinging this, in case it was buried under other messages and has escaped attention.
On 11/26/18 9:23 PM, Dimitris Papavasiliou wrote:
Sorry, I probably misunderstand. Do you propose removing the "Digital Playback Switch" control entirely? It would certainly simplify things, as far as implementing the .digital_mute callback is concerned, but it would remove the only way of manually muting the DAC. The "Digital Playback Volume" control is the main (and basically sole, apart from a switchable -6dB analog gain control) volume control of the DAC and removing the Switch component would make it unmutable.
The current implementation uses the control to keep track of the user's desired mute state and allows the .digital_mute callback to override it, in a way that is transparent to the user.