On Mon, Apr 22, 2024 at 02:43:52PM +0100, Srinivas Kandagatla wrote:
From: Srinivas Kandagatla srinivas.kandagatla@linaro.org
Add a common function to add Display port jack, this can be used by multiple board files and avoid any code duplication.
Signed-off-by: Srinivas Kandagatla srinivas.kandagatla@linaro.org
sound/soc/qcom/common.c | 29 +++++++++++++++++++++++++++++ sound/soc/qcom/common.h | 3 +++ 2 files changed, 32 insertions(+)
diff --git a/sound/soc/qcom/common.c b/sound/soc/qcom/common.c index 747041fa7866..3bfe618e7bd7 100644 --- a/sound/soc/qcom/common.c +++ b/sound/soc/qcom/common.c @@ -7,10 +7,14 @@ #include <sound/jack.h> #include <linux/input-event-codes.h> #include "common.h"
Missing newline.
+#define NAME_SIZE 32
static const struct snd_soc_dapm_widget qcom_jack_snd_widgets[] = { SND_SOC_DAPM_HP("Headphone Jack", NULL), SND_SOC_DAPM_MIC("Mic Jack", NULL),
- SND_SOC_DAPM_SPK("HDMI/DP0 Jack", NULL),
- SND_SOC_DAPM_SPK("HDMI/DP1 Jack", NULL),
- SND_SOC_DAPM_SPK("HDMI/DP2 Jack", NULL),
};
int qcom_snd_parse_of(struct snd_soc_card *card) @@ -239,4 +243,29 @@ int qcom_snd_wcd_jack_setup(struct snd_soc_pcm_runtime *rtd, return 0; } EXPORT_SYMBOL_GPL(qcom_snd_wcd_jack_setup);
+int qcom_snd_dp_jack_setup(struct snd_soc_pcm_runtime *rtd,
struct snd_soc_jack *hdmi_jack, int hdmi_pcm_id)
The function is called dp_jack_setup() so shouldn't the parameters reflect that and be called dp_jack etc. for consistency (i.e. even if you plan on using this interface also for hdmi)?
Johan