On Fri, May 01, 2015 at 09:15:10AM -0500, Pierre-Louis Bossart wrote:
Maybe I confused everyone, it's not complicated: there is a register that indicates if the DSP is enabled and that can be queried before launching the DSP driver. There is no guessing or need for DMI-based quirks, the capabilities are exposed and that should be used. You can then add a driver parameter to fall back to legacy mode, e.g. for testing, but that would be a second level disable. For once the hardware does tell us what to do, we need to use the information...
Oh, OK. That sounds sensible! If that's the case then surely we should just have one driver for the PCI ID which just skips enabling the DSP bits based on a combination of the register and the driver parameter? We shouldn't need this multiple drivers for the same PCI ID stuff.