On Tue, 25 Apr 2017 00:18:31 +0200, Pierre-Louis Bossart wrote:
On 4/24/17 4:45 PM, Takashi Iwai wrote:
On Mon, 24 Apr 2017 23:39:47 +0200, Pierre-Louis Bossart wrote:
On 04/24/2017 07:09 AM, Takashi Iwai wrote:
The FE setups of Intel SST bytcr_rt5640 and bytcr_rt5651 drivers carry the ignore_suspend flag, and this prevents the suspend/resume working properly while the stream is running, since SST core code has the check of the running streams and returns -EBUSY. Drop these superfluous flags for fixing the behavior.
Also, the bytcr_rt5640 driver lacks of nonatomic flag in some FE definitions, which leads to the kernel Oops at suspend/resume like:
This patch also fixes the known bug that reboot had to be forced on some BYT platforms with a manual restart when the audio driver was enabled. Thanks Takashi!
While we're at it: could you submit the UCM profiles as alsa-lib upstream? At least the ones for the drivers that are in the current kernel should be merged.
If there are multiple board-specific UCMs for the same driver, we can use now card's longname (generated from DMI string) as the primary source, while keeping the $DRIVER/$DRIVER.conf as the fallback.
Well I've lost track of which git repo UCM files should be in, both the license and the update rate of alsa-lib are problematic for configuration files.
The split to another repo is planned but doesn't happen yet. I guess we'll do it after 1.1.4 release. So far, you can submit the existing files just to alsa-lib as is unless you want inevitably another license.
We also talked about some include capabilities to avoid copy/paste but I can't recall having seen them upstream.
Hm, it's basically always possible as an alsa-lib config feasture, but never used. We can work on it later once after gathering the similar profiles.
I also haven't had time to test the long name on my devices.
That's OK, we can begin with the basic ones such as bytcr_rt5640.conf. The longname stuff is new and will be available at first in 3.12, so it's a feature in near future.
thanks,
Takashi