25.11.2021 15:28, Mark Brown пишет:
On Thu, Nov 25, 2021 at 03:04:35PM +0300, Dmitry Osipenko wrote:
25.11.2021 15:02, Mark Brown пишет:
On Thu, Nov 25, 2021 at 01:00:44AM +0300, Dmitry Osipenko wrote:
Program FIFO trigger level properly to fix x4 accelerated playback.
Fixes like this should really go before any new stuff so they can be sent as fixes and backported.
This driver never worked before this patchset, hence there is nothing to backport, this is explained in the cover letter. But in general you're correct.
That's not going to stop the stable people backporting things, and I'd guess it might've worked at some point on some systems - I'm not seeing anything that jumps out as making the driver completely unworkable in your patches.
I can change commit message with the "fix" word removed, this should prevent patch from backporting.
This driver never worked in mainline because S/PDIF device was never created, thus driver was never bound. Driver doesn't work properly without this patch. Nobody used this driver as-is before this patchset.