15 Feb
2019
15 Feb
'19
6:02 p.m.
On Fri, Feb 15, 2019 at 06:48:26PM +0200, Daniel Baluta wrote:
--- a/sound/soc/generic/simple-card.c +++ b/sound/soc/generic/simple-card.c @@ -445,7 +445,7 @@ static int simple_for_each_link(struct simple_priv *priv, /* Check if it has dai-link */ node = of_get_child_by_name(top, PREFIX "dai-link"); if (!node) {
node = top;
node = of_node_get(top); is_top = 1; }Not sure if is correct, though.
That looks correct to me, of_get_child_by_name() takes a reference we'll need to drop later so when we substitute in top we need to take a reference as well as just assigning. Can you or someone put together a proper patch please?