Hi Ryan
About this max98373->codec. This user is only max98373_set_clock(), and it is called from max98373_dai_hw_params(). You are getting *codec from dai->codec in this function, and max98373 is came from it. This means, we can remove max98373->codec ?
Thanks for your feedback. I will remove max98373->codec and change related things.
Thanks
I'm sorry but I don't fully understand the benefit of this. Keeping regmap information in private driver data is very common and I can see many ASoC drivers are using it. I was able to see only a few driver use ' snd_soc_component_read'. I would like to keep regmap_read/write if it is still acceptable.
I checked other drivers. Having private regmap seems a little bit duplicate for me, because we can get it from component or dev. But sometimes, in some drivers, it seems can be difficult. Sorry for my noise.
Best regards --- Kuninori Morimoto