On Sat, 09 Apr 2022 03:26:55 +0200, Fabio M. De Francesco wrote:
Syzbot reports "KASAN: null-ptr-deref Write in snd_pcm_format_set_silence".[1]
It is due to missing validation of the "silence" field of struct "pcm_format_data" in "pcm_formats" array.
Add a test for valid "pat" and, if it is not so, return -EINVAL.
[1] https://lore.kernel.org/lkml/000000000000d188ef05dc2c7279@google.com/
Reported-and-tested-by: syzbot+205eb15961852c2c5974@syzkaller.appspotmail.com Signed-off-by: Fabio M. De Francesco fmdefrancesco@gmail.com
Thanks, applied now.
I wasn't able to figure out the commit for the "Fixes:" tag. If this patch is good, can someone please help with providing this missing information?
That must be present from the very beginning. I just add Cc-to-stable for allowing backport to all releases.
thanks,
Takashi