17 Oct
2013
17 Oct
'13
4:10 p.m.
On Thu, Oct 17, 2013 at 03:51:54PM +0200, Lars-Peter Clausen wrote:
On 10/17/2013 03:37 PM, Timur Tabi wrote:
I understand that, but I'm trying to figure out why of_iomap() is okay for hundreds of other drivers, but not this one. I've used it dozens of times myself, without ever worrying about overlapping regions.
The driver would work fine with just of_iomap(). But the resource range check comes basically for free and it does help to catch errors, so I'd recommend on using it rather than not using it.
There's also the fact that it's a devm_ function which means less error handling code that we can break which is nice. There's probably a case for an improved OF helper here...