On Fri, 21 Jul 2023 12:42:08 +0200, Andy Shevchenko wrote:
On Fri, Jul 21, 2023 at 12:08:46PM +0200, Takashi Iwai wrote:
On Fri, 21 Jul 2023 12:01:46 +0200, Andy Shevchenko wrote:
The sockptr_t (despite the naming) is a generic type to hold kernel or user pointer and there are respective APIs to copy data to or from it. Replace open coded variants in the driver by them.
While I see the benefit, I feel this is very confusing. If we use the API for a generic use, it should be renamed at first.
Also, the current function actually follows the call pattern, and we know in the caller side whether it's called for a kernel pointer or a user pointer. So, if any, the PCM core callbacks should be revised to use a generic pointer instead of fiddling in each driver side.
Any suggestion for the name?
It's a universal pointer... uniptr_t? Or a generic pointer, genptr_t?
I'm not good at naming, and I'm open for it.
And I believe for the bigger series the new callback should be added first.
Yes.
Takashi