On Monday 11 May 2009 15:03:20 ext Jarkko Nikula wrote:
On Mon, 11 May 2009 14:14:25 +0300
Peter Ujfalusi peter.ujfalusi@nokia.com wrote:
This patch fixes the - agressive - 'tuck' sound heard when the codec goes to standby mode.
We need to wait for the ramp down completion in case of headsetl_event:POST_PMD.
For my ears this sounds that the power-down pop is now even worse. I'm listening with some 32 ohm headphones connected into Beagle.
Before it was kind of sharp snap but now it is snap + low-frequency tuck/pop. Positive that this low-frequency pop sounds kind of same than the power-up pop so there is now ramp in both events when coupling capasitor is charging/discharging.
Do you know is the capacitor coupling configuration correct? TPS65950 is mentioning it but I don't find it at quick look where to configure it for ac-coupled connection.
Jarkko and others: can you test this on top of the my patch? How does the 'tuck' sounds after this?
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 7847f80..f930fbc 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -61,7 +61,7 @@ static int dapm_up_seq[] = {
static int dapm_down_seq[] = { snd_soc_dapm_pre, snd_soc_dapm_adc, snd_soc_dapm_hp, snd_soc_dapm_spk, - snd_soc_dapm_pga, snd_soc_dapm_mixer_named_ctl, snd_soc_dapm_mixer, + snd_soc_dapm_mixer_named_ctl, snd_soc_dapm_mixer, snd_soc_dapm_pga, snd_soc_dapm_dac, snd_soc_dapm_mic, snd_soc_dapm_micbias, snd_soc_dapm_mux, snd_soc_dapm_value_mux, snd_soc_dapm_supply, snd_soc_dapm_post