Re: [PATCH v3 14/42] power: reset: Add a driver for the ep93xx reset

Hi Andy!

On Fri, 2023-07-21 at 19:37 +0300, Andy Shevchenko wrote:

...

+       /* Issue the reboot */

^^^^^^^^^^^^^^^^^^^^^^ This is the relevant comment, one can extend it, but looks already quite informative considering EP93XX_SYSCON_DEVCFG_SWRST register name.

But Nikita would be able to include more verbose comment if you'd have a suggestion.

...

+       ep93xx_devcfg_set_clear(priv->map, EP93XX_SYSCON_DEVCFG_SWRST, 0x00); +       ep93xx_devcfg_set_clear(priv->map, 0x00, EP93XX_SYSCON_DEVCFG_SWRST);

...

+       mdelay(1000);

Atomic?! Such a huge delay must be explained, esp. why it's atomic.